Re: [Qemu-devel] [patch]Fix block device read for some SLOW file

[Johannes Schindelin]

Hi,

On Wed, 27 Jul 2005, lepton wrote:

> +    while(1){
> +     ret = read(s->fd, buf, nb_sectors * 512);
> +     if (ret != nb_sectors * 512) {
> +             if(ret==-1 && errno==EINTR)
> +                     continue;
> +             else
> +                     return -1;
> +     }
> +     return 0;
> +    }

Why not

do {
        ret = read(s->fd, buf, nb_sectors * 512);
} while(ret==-1 && errno=EINTR);

if (ret != nb_sectors * 512)
        return -1;
return 0;

Ciao,
Dscho