Re: [Qemu-devel] [Patch Submission] QEMU with GCC/Win32

[Gwenole Beauchesne]

On Sun, 31 Jul 2005, Paul Brook wrote:

> The gcc4 changes are a different matter.  I discusses this with Fabrice on 
> IRC 
> shortly after submitting the patch. The patch is pretty invasive, high risk, 
> and potentially hard to debug and maintain.

Talking of which, I don't know if I have sent you this patch but I see it
lying in my old home dir for submission. IIRC, I hit the imul case in real 
condition, the others are from further inspection from the manual.

--- dyngen.c.orig       2005-06-02 21:41:51.000000000 +0200
+++ dyngen.c    2005-06-02 22:19:59.000000000 +0200
@@ -1672,14 +1672,19 @@
                 is_prefix = 1;
                 break;
             case 8: /* push immediate */
-            case 10: /* pop immediate */
                 immed = op_size;
                 modrm = 0;
                 break;
+            case 10: /* push 8-bit immediate */
+                immed = 1;
+                modrm = 0;
+                break;
             case 9: /* imul immediate */
-            case 11: /* imul immediate */
                 immed = op_size;
                 break;
+            case 11: /* imul 8-bit immediate */
+                immed = 1;
+                break;
             case 12: /* insb */
             case 13: /* insw */
             case 14: /* outsb */