[Qemu-devel] [PATCH] fix Mac OS X cocoa modifier keys behavior

[Joachim Henke]

With current CVS, when running Linux as guest OS, the kernel log is
flooded with messages like


atkbd.c: Unknown key pressed (translated set 2, code 0x0 on isa0060/serio0).
atkbd.c: Use 'setkeycodes 00 <keycode>' to make it known.
atkbd.c: Unknown key released (translated set 2, code 0x0 on isa0060/serio0).
atkbd.c: Use 'setkeycodes 00 <keycode>' to make it known.


if the command key is pressed. The same even occurs, when you're
typing in the Qemu Monitor. This is because the cocoa frontend uses
the value 0 for undefined (or invalid) keys like the command key, but
forwards them to the guest OS without checking.

The attached patch
- solves the problem described above
- avoids passing modifier keys to the guest OS when typing in the Monitor
- fixes the bug that the mouse cursor grab is released with _any_ modifier key
  (should be only ctrl+alt)
- removes some code redundancies


Fabrice, please apply.

Thanks
        Jo

osx_cocoa.diff.gz
Description: GNU Zip compressed data