Re: [Qemu-devel] [PATCH] lba48 support

[Fabrice Bellard]

Jens Axboe wrote:
> Saw the posts on this the other day and had a few spare hours to play
> with this. Works for me, with and without DMA (didn't test mult mode,
> but that should work fine too).
>
> Test with caution though, it's changing the ide code so could eat your
> data if there's a bug there... Most clever OS's don't use lba48 even for
> lba48 capable drives, unless the device is > 2^28 sectors and the
> current request is past that (but they could be taking advantage of the
> larger transfer size possible, in which case lba48 will be used even for
> low sectors...).

Thank you for the patch ! At least two details should be corrected 
before I can apply it:

1) Each duplicated IDE register acts as a 2 byte FIFO, so the logic you 
added in the write function should be modified (the regs_written field 
is not needed).

2) The read back logic should be implemented (HOB bit in the device 
control register).

Fabrice.