Re: [Qemu-devel] Updated BGR vs. RGB vga patch...

[Leonardo E. Reiter]

By the way, I did verify that the patch works correctly in B/G/R 5/6/5 
mode - I wasn't sure about 16-bit BGR before.  However, in 16-bit mode, 
only -std-vga works correctly if the X server is in BGR mode.  In 24-bit 
BGR mode, cirrus has no problem.  I think there is some 16-bit trickery 
going on in the cirrus implementation, but I haven't had much time to 
figure it out.  Also the cirrus implementation is really hard to follow 
for me, so if anyone has any idea, I'd appreciate it.

Thanks,

Leo Reiter

malc wrote:
> On Mon, 10 Apr 2006, Leonardo E. Reiter wrote:
>
> > Anyway, I didn't spend time figuring out how to query SDL for the 
> > ordering. You still have to manually pass in -bgr.  The good news is 
> > that all the computation is now done at compile-time, with only very 
> > few tests done at run-time.  I agree with your assessment of 
> > compile-time versus run-time options... I was merely suggesting a 
> > compromise to fend off the minor performance hit of using the old 
> > patch.  But the method you suggested is much better and that's how 
> > it's implemented now.
>
>
> I maybe going out on a limb here, but isn't rgb/bgr trivially deducible
> from: sdl.c:screen->format->[RGBA]shift.

--
Leonardo E. Reiter
Vice President of Product Development, CTO

Win4Lin, Inc.
Virtual Computing from Desktop to Data Center
Main: +1 512 339 7979
Fax: +1 512 532 6501
http://www.win4lin.com