qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] Fix scrambling of >32KB packets in slirp


From: Ed Swierk
Subject: [Qemu-devel] [PATCH] Fix scrambling of >32KB packets in slirp
Date: Sun, 30 Apr 2006 19:55:42 -0700

In several places in qemu's slirp code, signed and unsigned ints are
used interchangeably when dealing with IP packet lengths and offsets.
This causes IP packets greater than 32K in length to be scrambled in
various interesting ways that are extremely difficult to troubleshoot.

Although large IP packets are fairly rare in practice, certain
UDP-based protocols like NFS use them extensively.

The attached patch wraps IP packet lengths and offsets in macros that
ensure they are always properly treated as unsigned values.

--Ed

Attachment: qemu-slirp-32k-packets.patch
Description: Text Data


reply via email to

[Prev in Thread] Current Thread [Next in Thread]