qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] -cc checking wrong


From: Jim C. Brown
Subject: Re: [Qemu-devel] -cc checking wrong
Date: Sun, 7 May 2006 20:18:55 -0400
User-agent: Mutt/1.4.2.1i

On Mon, May 08, 2006 at 12:46:24AM +0200, Pavel Jan?k wrote:
> configure contains:
> 
> if [ ! -x "`which $cc`" ] ; then
>     echo "Compiler $cc could not be found"
>     exit
> fi
> 
> You should check if the command compiles, not if it exists and is executable.

Patch attached. Simply tries to compile a dummy program.

> Two wrongs do not make a right.
>                   -- Linus Torvalds in linux-kernel

I find that quote very ironic ... ;)

-- 
Infinite complexity begets infinite beauty.
Infinite precision begets infinite perfection.

Attachment: configure.patch
Description: Text document


reply via email to

[Prev in Thread] Current Thread [Next in Thread]