Re: [Qemu-devel] [PATCH] VLAN and Tap for win32

[Fabrice Bellard]

Kazu wrote:
> Hi,
>
> VLAN and Tap patches for win32 are updated. I added handling for wait
> objects.
>
> http://www.h7.dion.ne.jp/~qemu-win/download/qemu-0.8.1-vlan.patch

I don't undertand this patch: the connect() is meant to be non blocking 
so the 'socket_wait_event' just after is not correct. The wait for the 
connection must be done inside the QEMU main loop as it is done on the 
Unix target (connect() on Unix in non blocking mode usually return 
EINPROGRESS and we can wait for the connection using select()).

> http://www.h7.dion.ne.jp/~qemu-win/download/qemu-0.8.1-tap.patch

OK for this one. Suppressing all the remaning polling in the win32 
version would be good. In particular, it would be good to be able to 
wait for network events while waiting for other events.

Regards,

Fabrice.