Re: [Qemu-devel] [PATCH 1/5] single step with no IRQs and timers

[Daniel Jacobowitz]

On Sat, May 20, 2006 at 04:01:10PM -0500, Jason Wessel wrote:
> +    case 'q':
> +        /* parse any 'q' packets here */
> +        if (!strcmp(p,"sstepbits")) {

Hi Jason,

Not that I'm always good about this myself, but could I ask you to
follow this paragraph from the GDB manual, since these are commands
unlikely to be supported by a general GDB (at least not unless someone
proposes them...):

   * The names of custom vendor packets should use a company prefix, in
     lower case, followed by a period.  For example, packets designed at
     the Acme Corporation might begin with `qacme.foo' (for querying
     foos) or `Qacme.bar' (for setting bars).

Company name could be whatever here - either wrs or qemu, I suppose,
probably qemu.  By that logic it would probably be Qqemu.sstep=5, too,
though that's less important.  The goal is of course not to conflict
with later versions of GDB.

And thanks for doing this!  What a great idea!

-- 
Daniel Jacobowitz
CodeSourcery