Re: [Qemu-devel] [PATCH] mips-user socket-related syscall support

[Fabrice Bellard]

Raphaël Rigo wrote:
> Raphaël Rigo wrote:
>
> > Fabrice Bellard wrote:
> >
> > > Another point is that doing:
> > >
> > > +    target_long args[6];
> > > +
> > > +    tputl(args, arg1);
> > > +    tputl(args+1, arg2);
> > > +    tputl(args+2, arg3);
> > > +    tputl(args+3, arg4);
> > > +    tputl(args+4, arg5);
> > > +    tputl(args+5, arg6);
> > >
> > > at the start of every syscall is not acceptable. You should add a
> > > specific socket call wrapper which takes arg1... arg6 as arguments.
> > >
> > > Regards,
> > >
> > > Fabrice.
> >
> > Thanks for reviewing it, the new attached version should be much cleaner.
> >
> > Regards,
> > Raphaël
>
> Sorry to insist, but can you please include it in the CVS? I really think it's
> useful.

I applied it and added "getsockopt". In fact, you should completely 
suppress do_socketcallwrapper() (using tputl and tgetl for non user 
access is bad).

Regards,

Fabrice.