Re: [Qemu-devel] [usb] call destroy for usb devices upon removal from guest

[Lonnie Mendez]

On Tue, 2006-07-18 at 23:46 +0200, Fabrice Bellard wrote:
> Lonnie Mendez wrote:
> > lo list.  I have found the old diff to be incorrect on many levels.  New
> > diff has additionally cleanup code for the linux redirector.  Please see
> > the attached patch for solution.
> 
> Forget my last comment - I understand the problem now. I think it was a 
> bad idea to use 'usb_reset' to destroy the usb device. Ideally a 
> specific method should be added because it has no relation with the USB 
> protocol (it is used to clear resources and it is perfectly possible 
> that a given device can be inserted, removed and inserted again without 
> having been destroyed). Another point is that the unused message 
> 'USB_DESTROY' should be... destroyed.

   Attached is a new diff that implements your suggestions.  I have
compiled and run tested the patch against cvs.

qemu-usb-cleanup2.diff
Description: Text Data