Re: [Qemu-devel] [PATCH] lance.c emulation corrections

[Blue Swirl]

> > It could be worthwhile to check if lance (Am7990) and pcnet (Am79C970A)
> > drivers could be merged. This was discussed briefly some years ago:
> > http://lists.gnu.org/archive/html/qemu-devel/2004-10/msg00364.html
>
> Yes, a quick look shows 79c970a has one rx/tx buffer management mode which
> is software-compatible with 7990 chip (SWMODE=0) There may be more
> backward-compatibility bits to be unified. Anyone? :)

Looks like only 32-bit modes are implemented in pcnet.c and endianness 
issues should be checked.

The files could be reorganised to for example pcnet-common.c, pcnet-pci.c, 
and pcnet-lance.c or just throw everything together with small performance 
penalty and unwanted code for both lance and pcnet. Opinions?

_________________________________________________________________
Express yourself instantly with MSN Messenger! Download today it's FREE! 
http://messenger.msn.click-url.com/go/onm00200471ave/direct/01/