[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Re: PCNet and Lance merge, almost there
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] Re: PCNet and Lance merge, almost there |
Date: |
Thu, 24 Aug 2006 20:30:06 +0100 |
User-agent: |
KMail/1.9.3 |
> > >ultimately there will be a single QEMU executable supporting all
> > > machines and CPUs. In the pcnet case for example, the macro
> > > 'SPARC_FIX_DESC' is almost surely not necessary because the device
> > > seems implicitely little endian (the original code lacks correct
> > > endianness conversion routines
> >
> > !).
> >
> > That's what I suspected. I'll try to make an universal version.
>
> Do you want to preserve bitfields in structures? See comments near
> PACKED_FIELD() decl
Relying on bitfields having a particular memory layout is generally a bad
idea. For any code that relies on a particular bit layout I strongly suggest
avoiding bitfields and using explicit shift/mask or a conversion routine that
converts from guest memory to host struct formats.
Paul
- [Qemu-devel] PCNet and Lance merge, almost there, Blue Swirl, 2006/08/24
- [Qemu-devel] Re: PCNet and Lance merge, almost there, Fabrice Bellard, 2006/08/24
- [Qemu-devel] Re: PCNet and Lance merge, almost there, Blue Swirl, 2006/08/24
- Re: [Qemu-devel] Re: PCNet and Lance merge, almost there, Igor Kovalenko, 2006/08/24
- Re: [Qemu-devel] Re: PCNet and Lance merge, almost there,
Paul Brook <=
- Re: [Qemu-devel] Re: PCNet and Lance merge, almost there, Blue Swirl, 2006/08/24
- Re: [Qemu-devel] Re: PCNet and Lance merge, almost there, Fabrice Bellard, 2006/08/24