[Qemu-devel] Re: PCNet & Lance merge

[Fabrice Bellard]

Blue Swirl wrote:
> Hi,
>
> These patches merge PCNet and Lance, implement the new IOMMU access 
> method and convert ESP and PCNet to use the new method.
>
> At least Sparc works as before. I think the changes should not change PC 
> use of PCNet.

Still one remark: using bswap() is almost surely a bug (what if the host 
CPU is big endian ?). For correct code, you must use le16_to_cpu() or 
be16_to_cpu().

Regards,

Fabrice.