qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] PCI Bios fixup


From: Samuel Thibault
Subject: [Qemu-devel] PCI Bios fixup
Date: Thu, 7 Sep 2006 03:02:29 +0200
User-agent: Mutt/1.5.12-2006-07-14

Hi,

The patch that qemu applies to bochs bios is a bit bugged:

 pci_pro_fail:
   pop edi
   pop esi
-  sti
   popf
   stc
+  and dword ptr[esp+4],0xfffffffc ;; reset CS.RPL for kqemu
   retf

The and operation clears carry... So that pci functions always leave
carry clear, and hence tell operating systems that they always work...
This should rather be:

 pci_pro_fail:
   pop edi
   pop esi
-  sti
   popf
+  and dword ptr[esp+4],0xfffffffc ;; reset CS.RPL for kqemu
   stc
   retf

Samuel




reply via email to

[Prev in Thread] Current Thread [Next in Thread]