|
| From: | Fabrice Bellard |
| Subject: | Re: [Qemu-devel] block-vvfat RW patch |
| Date: | Sat, 09 Sep 2006 14:05:43 +0200 |
| User-agent: | Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.3) Gecko/20040913 |
Roger Lathrop wrote:
3) Changed sector2cluster to return a signed int, and added type casts to force the division to be signed.
This is not safe. vvfat_write must be modified to handle the case where sectors are written before s->faked_sectors (maybe ignoring the write could suffice).
Regards, Fabrice.
| [Prev in Thread] | Current Thread | [Next in Thread] |