[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] Fix char signedness
From: |
Rob Landley |
Subject: |
Re: [Qemu-devel] [PATCH] Fix char signedness |
Date: |
Sat, 28 Oct 2006 14:58:33 -0400 |
User-agent: |
KMail/1.9.1 |
On Friday 27 October 2006 7:09 pm, Paul Brook wrote:
> > > > It has been a really long time I have been working on a broken system
> > > > that did not default to "signed".
> > >
> > > The only thing that is broken is your knowlege of C.
> >
> > Okay.
> >
> > And what system did you encounter this behaviour on?
>
> Common arm, ppc, s390 and mips systems all have default char as unsigned.
> As do a few other less common embedded systems.
BusyBox added "-funsigned-char" to our build to get consistent behavior. (I
picked unsigned because that way we were automatically 8-bit clean in things
like sed.)
(I note that tcc doesn't work right if built with -funsigned-char, so I
wouldn't be too surprised if qemu had the same problem.) In both cases,
specifying -fsigned-char in the build should fix it.
> Paul
Rob
--
"Perfection is reached, not when there is no longer anything to add, but
when there is no longer anything to take away." - Antoine de Saint-Exupery