Re: [Qemu-devel] [patch] add configure check for working alsa

[Paul Brook]

On Thursday 04 January 2007 15:02, Bernhard Fischer wrote:
> Hi,
>
> This patchlet adds a check to configure that makes sure that we have a
> working alsa setup.
>
> Previously, if --enable-alsa was given but the user forgot to install
> the alsa libs proper, the build failed later on due to eventually
> missing libs. The patch makes sure that the user can spot that alsa
> support was turned off after configuration completed.

This is wrong. If the user requests alsa we should honour that request, or 
fail trying. We should never quietly ignore an explicit user decision.

Making configure fail early with an error is acceptable (as it the current 
link failure). Ignoring --enable-alsa is not.

Paul