Re: [Qemu-devel] [PATCH] -parallel and -serial on Windows host - second try

[Johannes Schindelin]

Hi,

On Sat, 13 Jan 2007, Bernhard Fischer wrote:

> On Fri, Jan 12, 2007 at 11:36:06AM -0800, alex wrote:
> 
> >
> >--- /d/qemu/vl.c Fri Jan 12 10:43:12 2007
> >+++ vl.c Fri Jan 12 10:49:37 2007
> >@@ -2692,8 +2692,13 @@
> >             if (ret < 0) {
> >                 err = socket_error();
> >                 if (err == EINTR || err == EWOULDBLOCK) {
> >+#ifndef _WIN32
> >                 } else if (err == EINPROGRESS) {
> >                     break;
> >+#else
> >+                } else if (err == EINPROGRESS | err == WSAEALREADY) {
> 
> Doesn't sound like it would be correct ("|" != "||"), even for Windows.. 

Well, it might be not intended, but it still works correctly: "==" has a 
higher priority than "|", and the value of "err == EINPROGRESS" is 0 or 1, 
depending on the value of EINPROGRESS. It is never anything else but 0 or 
1, so the operator "|" has the same result as "||" (at least in this 
case).

Ciao,
Dscho