Re: [Qemu-devel] [PATCH] PIIX4 SMBus host, EEPROM device emulation

[Ed Swierk]

On 1/23/07, Fabrice Bellard <address@hidden> wrote:
> OK, but avoid using mmap() in the device code. Moreover, files in the
> BIOS directory are not writable.

OK. Would it be better to do the following:

- add a command-line option -seeprom that sets the file to use as
backing store for the smbus_eeprom device

- in main(), open and mmap the file if the -seeprom option is
specified, otherwise allocate a temporary buffer

- add a seeprom buffer argument to each machine's init(), ignored except for pc

--Ed