Re: [Qemu-devel] [PATCH] ARM MMU translation - fix small (4k) page access

[Justin Fletcher]

On Fri, 2 Feb 2007, Justin Fletcher wrote:

> On Fri, 2 Feb 2007, Scott Oom wrote:
>
> > Hello,
> > Found a problem when using small pages and getting permission faults.
> > This patch corrects the decoding of access permissions for small pages
> > on ARM, was just off by 2 bits.
>
> I may be confused on this, but it still doesn't seem right to me.
>
> You have...
>
> -                ap = (desc >> (4 + ((address >> 13) & 6))) & 3;
> +                ap = (desc >> (4 + ((address >> 11) & 6))) & 3; /* SRO */

'sokay... I twigged whilst I was away from the machine that that 11 and 
the 6 is to ensure that the address is shifted up by 1 bit so that the 
desc shift is in the right place. Just me being confused, ignore me.

--
Gerph <http://gerph.org/>
... Caught up in circles, confusion is nothing new.