[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu/hw ide.c
From: |
Thiemo Seufer |
Subject: |
Re: [Qemu-devel] qemu/hw ide.c |
Date: |
Mon, 19 Feb 2007 12:23:33 +0000 |
User-agent: |
Mutt/1.5.13 (2006-08-11) |
Jens Axboe wrote:
> On Mon, Feb 19 2007, Thiemo Seufer wrote:
> > Jens Axboe wrote:
> > > On Mon, Feb 19 2007, Thiemo Seufer wrote:
> > > > CVSROOT: /sources/qemu
> > > > Module name: qemu
> > > > Changes by: Thiemo Seufer <ths> 07/02/19 00:59:34
> > > >
> > > > Modified files:
> > > > hw : ide.c
> > > >
> > > > Log message:
> > > > Ignore special flags in nsector variable.
> > > >
> > > > CVSWeb URLs:
> > > > http://cvs.savannah.gnu.org/viewcvs/qemu/hw/ide.c?cvsroot=qemu&r1=1.53&r2=1.54
> > >
> > > Why is nsector uint32_t to begin with?
> >
> > Because nobody sent a patch to fix it, I figure.
>
> Actually I seem to recall it's because it's being overloaded for
> requests that are > 256 sectors. It would be a good cleanup to get rid
> of that an turn nsector into a proper uint8_t.
It appears to use 16k bits in some cases. I won't fiddle with it myself
because I know nothing about IDE and have no time to learn about it.
Thiemo