Re: [Qemu-devel] PATCH: allow Sparc hosts to run arm/mips/sparc-softmmu

[Paul Brook]

> However, it's very wax-on, wax-off kind of thing.  Without the patch,
> arm-test and mips-test crash.  With the patch, I can run both tests.

As I've said before it's not sufficient to say that a patch fixes a bug, you 
have to explain *what* bug you are fixing, *how* it fixes the bug, and *why* 
it's the correct way to fix it. In order to review the patch I need to be 
able to follow your logic for creating the patch. If you don't understand the 
patch you should not be submitting it.

In this specific case:

* What: "qemu crashes" is not a particularly useful description of the failure 
mode. I want to know how (eg. segfault, abort, infinite loop, does wrong 
thing) it crashes, which bit of code it's executing when it crashes, and how 
it got to that point.

* How: I'm also not convinced your #ifdef does what you think it does, though 
It's somewhat unclear what you're trying to achieve. I'm guessing you 
intended to disable the code on sparc hosted arm+mips targets 

* Why: "I randomly changed things until it started working" is not a valid 
justification for a change. Why doesn't this failure occur on other hosts? 
Why only arm and mips targets?

Paul