qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] scsi patch


From: Thiemo Seufer
Subject: Re: [Qemu-devel] scsi patch
Date: Mon, 19 Mar 2007 12:42:11 +0000
User-agent: Mutt/1.5.13 (2006-08-11)

????????? wrote:
> --- ../../tmp/qemu-0.9.0/hw/lsi53c895a.c        2007-02-06 07:01:
> 54.000000000 +0800
> +++ lsi53c895a.c        2007-03-08 20:50:03.094098835 +0800
> @@ -251,7 +251,7 @@
>     uint32_t ia;
>     uint32_t sbc;
>     uint32_t csbc;
> -    uint32_t scratch[13]; /* SCRATCHA-SCRATCHR */
> +    uint32_t scratch[18]; /* SCRATCHA-SCRATCHR */

This still looks inconsistent. SCRATCHR suggests 18 available
registers, but the code below handles only 17 scratch registers.

Could you check what's the right thing there?
Otherwise the patch looks good.


Thiemo




reply via email to

[Prev in Thread] Current Thread [Next in Thread]