Re: [Qemu-devel] [PATCH] Implement Win32 locking in vl.c (create_pidfile).

[Anthony Liguori]

Carlos O'Donell wrote:
> The following patch implements Win32 locking for vl.c (create_pidfile).
> Builds for mingw32, and tested on a Windows Server 2003 host by running
> two qemu's with the same -pidfile option.
>
> When cross-compiling the use of --enable-mingw32 should effect AIOLIBS,
> otherwise the build will use "-lrt" and this is not valid when compiling
> with mingw32.
>   

Instead of using an #ifdef, I think it would be better to have a win32 
specific file and a unix specific file that compiles conditionally 
depending on the host.

Sort of like and osdep-posix.c and and osdep-win32.c.  Both would 
implement a create_pidfile() function.  I think this general approach 
would help clean up a lot of the win32 code.

Thoughts?

Regards,

Anthony Liguori

> Patch attached for both. Built on linux and tested on Windows Server
> 2003.
>
> Comments? Please include me in the CC.
>
> Cheers,
> Carlos.
>