Re: [Qemu-devel] [PATCH] Guest mouse cursor drawing in SDL

[andrzej zaborowski]

Hi,

On 26/03/07, Anthony Liguori <address@hidden> wrote:
> andrzej zaborowski wrote:
> > Hi, sorry for late reply.
> >
> > On 21/03/07, Anthony Liguori <address@hidden> wrote:
> >> Do you think using the SDL cursor is all that useful?  As soon as gtk
> >> widgets get involved, the cursor becomes ARGB so in practice, I'm not
> >> sure that it's all that helpful.
> >
> > It's pretty cool that you have only one cursor and that it's either
> > "in the VM" or outside, and it's full hardware drawn. In addition
> > without it, I think you can't get cursor refreshes between the SDL
> > refresh callbacks. So with the patch the cursor movement is really
> > smooth and responsive, eliminating the SDL latency. I find it amazing
> > that it works :p
>
> Hrm, interesting.  I actually want to rethink the mouse interface again
> as I've been thinking that even if an absolute mouse isn't available,
> provided that you know the location of the guest cursor, you can
> implement a smarter grab/ungrab.

I was thinking about this too but the issue is with grabbing.
Ungrabbing is straight forward, but when you grab, you will need to
either move the host cursor to the location of guest cursor or the
other way (which would be some iterative converging algorithm).

> > I think VNC support is not a reason to drop this couple of lines in
> > sdl.c (cause there's no API changes related).
> >
> >>
> >> BTW, I've got the ALPHA_CURSOR working with VNC.. it's very sweet :-)
> >
> > Awesome! Are there screenshots?
>
> I could make them, but they just show a mouse in the window :-)  BTW,
> have you thought about how to integrate std-vga into the vmware vga
> device?  I took a look at it and it seems like it will be overly
> complicated based on the way VGA memory dirtying is done now.

Yeah, it will require changes in hw/vga.c but it doesn't look very
difficult or hacky.

Regards,
Andrew