Re: [Qemu-devel] qemu Makefile.target vl.h hw/acpi.c hw/adlib.c ...

[Fabrice Bellard]

Hi,

> I can only fix the code that I have access to.
>
> IMHO your request that I revert changes because they allegedly break code that 
> noone else has access to is unreasonable. My changes are a significant 
> cleanup to qemu internals.
>
> However if there is agreement from other maintainers I will revert my patch.

I don't think you need to revert your patch. Personally, I would have 
changed the following:

1) The code is more generic than IRQs, it can be applied to any logic 
signal, so the naming should show it.

2) I don't like hiding pointers in types, so I would use for example 
'QEMUSignal *' instead of 'qemu_irq'.

Regarding the PPC problem, maybe you could just revert the patches in 
the MIPS and PowerPC CPUs structures, as I don't think it is necessary 
to move the IRQ code at this level now.

BTW, I have a small PREP test image that I can publish.

I am planning since some time to add to the QEMU web site an automatic 
regression testing system which will automatically launch many OSes with 
the current CVS version. I had no time to do it recently, but if no one 
does it before I'll try to complete it !

Regards,

Fabrice.