qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] qemu/linux-user syscall.c


From: Paul Brook
Subject: Re: [Qemu-devel] qemu/linux-user syscall.c
Date: Mon, 28 May 2007 15:28:00 +0100
User-agent: KMail/1.9.7

>       Fix do_socketcall argument, by Daniel Jacobowitz.

> -  static long do_socketcall(int num, target_ulong vptr)   
> +  static long do_socketcall(int num, target_phys_addr_t vptr) 

What is this supposed to be fixing?
vptr is a target pointer, and is only ever used as an argument to tgetl.
I think the original type (target_ulong) is correct.

target_phys_addr_t isn't really meaningful for userspace emulation.
We don't have physical addresses, only target (target_ulong) and
host (void *) virtual addresses.

Paul




reply via email to

[Prev in Thread] Current Thread [Next in Thread]