[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu exec.c monitor.c
From: |
Paul Brook |
Subject: |
Re: [Qemu-devel] qemu exec.c monitor.c |
Date: |
Sun, 1 Jul 2007 19:26:08 +0100 |
User-agent: |
KMail/1.9.7 |
On Sunday 01 July 2007, Stefan Weil wrote:
> ANSI / POSIX do not define "wa" as mode string for fopen.
> I have no idea how many implementations of libc
> will fail with this mode which was introduced by
> the latest version of exec.c.
>
> The standard mode for append is just "a".
You are correct. I've fixed this.
> Even better (because it is faster and creates smaller
> log files for Windows) is "ab" for append and "wb"
> otherwise.
We're writing human-readable text, so opening in binary mode is IMHO fairly
dubious. If you really want fast logs/traces there are better ways to speed
it up.
Paul