Re: [Qemu-devel] [PATCH] ARM7TDMI emulation

[Paul Brook]

On Monday 02 July 2007, Ulrich Hecht wrote:
> Hi!
>
> This patch adds ARM7TDMI emulation with Thumb v1 (no BLX, no BKPT, ignore
> bit 0 on POP PC) and without CP15.

ARM_FEATURE_THUMB1 is a bad name for this. Thumb-1 covers both v4t and v5t. 
Thumb-2 is a completely new architecture revision which adds 32-bit 
instructions. 

You should add/use ARM_FEATURE_V5/ARCH(5) instead.

For added confusion some older documentation refers to v5t as "thumb2", or the 
second revision of the Thumb ISA. This should be ignored :-)

The ARM7TDMI implements the base updated abort model. You should either 
implement that, or pick a core (eg. 920t) that uses the base restored abort 
model.

Paul