Re: [Qemu-devel] PATCH 4/8: VeNCrypt basic TLS support

[Daniel P. Berrange]

On Tue, Jul 31, 2007 at 08:50:29PM -0500, Anthony Liguori wrote:
> Daniel P. Berrange wrote:
> >@@ -362,6 +365,7 @@ echo "  --enable-alsa            enable 
> > echo "  --enable-alsa            enable ALSA audio driver"
> > echo "  --enable-fmod            enable FMOD audio driver"
> > echo "  --enable-dsound          enable DirectSound audio driver"
> >+echo "  --enable-vnc-tls         enable TLS encryption for VNC server"
> > echo "  --enable-system          enable all system emulation targets"
> > echo "  --disable-system         disable all system emulation targets"
> > echo "  --enable-linux-user      enable all linux usermode emulation 
> > targets"
> >@@ -589,6 +593,16 @@ fi # -z $sdl
> > fi # -z $sdl
> > 
> > ##########################################
> >+# VNC TLS detection
> >+if test "$vnc_tls" = "yes" ; then
> >+  `pkg-config gnutls` || vnc_tls="no"
> >+fi
> >+if test "$vnc_tls" = "yes" ; then
> >+  vnc_tls_cflags=`pkg-config --cflags gnutls`
> >+  vnc_tls_libs=`pkg-config --libs gnutls`
> >+fi
> >+
> >+##########################################
> > # alsa sound support libraries
> 
> Since it's possible to probe for gnutls support, why not just enable it 
> by default and disable it if it's not available?

Sure I can make that change - I wasn't sure what people's preference for
this was so I took conservative approach of not enabling it unless it
is explicitly asked for. Happy to change it to enable by default if the
pkg-config probing succeeds, and allow a configure arg to explicitly
disable it.

> >diff -r a1fa771c6cf9 vl.c
> >--- a/vl.c   Tue Jul 31 14:50:01 2007 -0400
> >+++ b/vl.c   Tue Jul 31 14:50:03 2007 -0400
> >@@ -6458,7 +6458,7 @@ void main_loop_wait(int timeout)
> >             if (FD_ISSET(ioh->fd, &rfds)) {
> >                 ioh->fd_read(ioh->opaque);
> >             }
> >-            if (FD_ISSET(ioh->fd, &wfds)) {
> >+            if (!ioh->deleted && ioh->fd_write && FD_ISSET(ioh->fd, 
> >&wfds)) {
> >                 ioh->fd_write(ioh->opaque);
> >             }
> >         }
> >  
> 
> I thought this was fixed already.  At any rate, it should be a separate 
> patch.

Sorry, this chunk wasn't supposed to be included - I'll submit it as a
separate patch.

> >+#if CONFIG_VNC_TLS
> >+ssize_t vnc_tls_push(gnutls_transport_ptr_t transport,
> >+                 const void *data,
> >+                 size_t len) {
> >+    struct VncState *vs = (struct VncState *)transport;
> >+    int ret, lastErrno;
> >  
> 
> s/lastErrno/last_errno/g

Ok.


Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=|