Re: [Qemu-devel] [PATCH][RFC] SVM support

[Fabrice Bellard]

> This is a reworked version of the same patch, where I can now boot into
> a x86_64 Linux kernel.
> I rewrote all the access functions for the VMCB, so this time everything
> should work just fine on BE-machines. As suggested I moved the injection
> detection to translate.c, so the non-virtualized machine should be as
> fast as before (w/o svm support), while the virtual one got a speed
> boost from that as well.
> I removed the EIP hack and set EIP every time an interception occurs, so
> unlike the previous version this patch really should have no negative
> effect on speed any more.
>
> If any of the people on this list using SVM (kvm developers, maybe xen
> developers) could have a deep look into this I'd be really thankful.

Some notes:

- Saving and restoring CC_SRC and CC_DST is not correct as they do not 
belong to the real processor state. You must save and restore eflags 
correctly instead.

- Avoid using macros when inline functions suffice.

Regards,

Fabrice.