Re: [Qemu-devel] Mips guest

[Nigel Horne]

I suddenly remembered I'd forgotten to do a "make clean" after my last checkout 
(oops).

So I did that, and got this compilation error:

...
In file included from /home/njh/src/qemu/linux-user/syscall.c:4040:
/home/njh/src/qemu/linux-user/syscall.c: In function `do_syscall':
/usr/include/bits/unistd.h:62: sorry, unimplemented: inlining failed in call to 
'pread': recursive inlining
/home/njh/src/qemu/linux-user/syscall.c:63: sorry, unimplemented: called from 
here
make[1]: *** [syscall.o] Error 1
make[1]: Leaving directory `/home/njh/src/qemu/i386-linux-user'
make: *** [subdir-i386-linux-user] Error 2

This is because both unistd.h and linux/unistd.h are included. Remove unistd.h 
from line 27 and that compiles OK.

The next (similar) failure is in mmap.c:

...
/home/njh/src/qemu/linux-user/mmap.c:392: warning: comparison between signed 
and unsigned
/home/njh/src/qemu/linux-user/mmap.c: In function `mmap_frag':
/usr/include/bits/unistd.h:62: sorry, unimplemented: inlining failed in call to 
'pread': recursive inlining
/home/njh/src/qemu/linux-user/mmap.c:63: sorry, unimplemented: called from here
/home/njh/src/qemu/linux-user/mmap.c:139: warning: ignoring return value of 
`pread', declared with attribute warn_unused_result

Here the fix was on line 24 to replace #include <unistd.h> with <linux/unistd.h>

Then:

...
/home/njh/src/qemu/linux-user/flatload.c: In function `target_pread':
/usr/include/bits/unistd.h:62: sorry, unimplemented: inlining failed in call to 
'pread': recursive inlining
/home/njh/src/qemu/linux-user/flatload.c:63: sorry, unimplemented: called from 
here

Which needs the same fix at line 41.

I suspect these may break building on other OS's, so a cleaner fix will be 
needed.

The next compilation error is:

...
/home/njh/src/qemu/monitor.c:52: warning: function declaration isn't a prototype
/home/njh/src/qemu/monitor.c:61: error: array size missing in 'term_cmds'
/home/njh/src/qemu/monitor.c:62: error: array size missing in 'info_cmds'

The fix is to change term_cmds[] to *term_cmds, and similarly to info_cmds. 
This is less than optimal,
but it gets the code compiling pending a code tidy.

The good news is that with these fixes it all compiles and the mips guest runs 
again (note to self: remember
to run make clean ;-) )


-Nigel

--
Nigel Horne. Adjudicator, Arranger, Band Trainer, Composer, Tutor, Typesetter.
NJH Music, Barnsley, UK.  ICQ#20252325
address@hidden http://www.bandsman.co.uk

njh.vcf
Description: Vcard