qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] Re: [PATCH] vvfat mbr fixes


From: Lorenzo Campedelli
Subject: [Qemu-devel] Re: [PATCH] vvfat mbr fixes
Date: Sun, 23 Sep 2007 22:17:42 +0200
User-agent: Thunderbird 1.5.0.12 (X11/20070719)

Johannes Schindelin wrote:
Hi,

On Sun, 23 Sep 2007, Lorenzo Campedelli wrote:

I was concerned by having this handling outside of a proper place (i.e. block-vvfat.c), but if we want to leave it there, wouldn't it be better to just handle cases which would otherwise fail, and just try to fix the "fat:" format?

I don't like that option, since it special-cases vvfat to much.

Ciao,
Dscho




I agree the fix is ugly, otoh the problem is also a special case...
I don't see a clean way of fixing this, the code in block.c needs to know how to handle a vvfat specific filename format.

I'll keep my "works for me" patch waiting for some better fix.

Thanks for your time.
Lorenzo





reply via email to

[Prev in Thread] Current Thread [Next in Thread]