Re: [kvm-devel] [Qemu-devel] expose host CPU features to guests: Take 3

[Dan Kenigsberg]

On Tue, Sep 25, 2007 at 03:28:24AM +0200, andrzej zaborowski wrote:
> Hi,
> 
> On 24/09/2007, Dan Kenigsberg <address@hidden> wrote:
> > As with previous "Takes" of this patch, its purpose is to expose host
> > +{
> > +    asm("cpuid"
> > +        : "=a" (*ax),
> > +          "=b" (*bx),
> > +          "=c" (*cx),
> > +          "=d" (*dx)
> > +        : "a" (function));
> > +}
> 
> I haven't really read through the rest of your code but this piece
> appears to be outside any #ifdef/#endif so it will only build on x86.

I might be missing something here, but isn't not being on the
TARGET_PATH of Makefile.target enough? I don't see #ifdef TARGET_I386
elsewhere under target-i386. I don't mind adding extra protection, I
just be happy to better understand the whats and whys.

Dan.