[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu...
From: |
Thiemo Seufer |
Subject: |
Re: [Qemu-devel] qemu linux-user/qemu.h linux-user/signal.c linu... |
Date: |
Thu, 27 Sep 2007 17:47:19 +0100 |
User-agent: |
Mutt/1.5.16 (2007-06-11) |
Thayne Harbaugh wrote:
[snip]
> > static inline target_ulong get_sp_from_cpustate(CPUPPCState *state)
> > {
> > return state->gpr[1];
> > }
> >
> > This is no way related to CPU emulation then has nothing to do in cpu.h.
> > Furthermore, there no notion of sigaltstack or even stack pointer in the
> > PowerPC specification.
> > Revert this patch immediatly, please, and stop breaking others code...
>
> My apologies. I put get_sp_from_cpustate() in cpu.h because it is a
> generic function that isn't exclusive to sigaltstack(). If it's
> preferred it can be exclusive to sigaltstack().
I moved it over to target_signal.h, which seems to be the best place
for the time being. I also enabled do_sigaltstack processing for
MIPS, PPC and Alpha, as I don't see a reason not to support it.
Thiemo