Re: [Qemu-devel] qemu/target-sparc exec.h op.c op_helper.c op_me...

[Andreas Färber]

Am 26.09.2007 um 13:05 schrieb Aurelien Jarno:

> Andreas Färber a écrit :
> > Am 23.09.2007 um 01:11 schrieb Aurelien Jarno:
> >
> > > > > Aurelien Jarno a écrit :
> > > > > > Thanks, that's helpful, it looks like the "lduba" instructions
> > > > > > is not
> > > > > > working correctly in your case. Now I have to find why.
> > > > > I don't really understand, because that is the part of the code  
> > > > > (at
> > > > > least from the op point of view) that is almost unchanged.
> > > > > Looking at
> > > > > the code again and again I can't see any problem.
> > > PS: I don't know if I will be able to get internet access in the
> > > next 4
> > > days.
> >
> > Just a short note that Blue Swirl's added break statements did not
> > change the results previously posted.
>
> Oh, I thought it was fixed by this commited.
>
> Looking at the data you sent in your last mail, it looks like the  
> lduba
> instruction is actually working correctly, given the first returned
> value is correct. But then it looks like the value is not correct  
> in the
>  cmp instruction as the wrong branch is taken.
>
> I have currently no idea why.

Okay, so this is the list of compiler warnings, configured with -- 
prefix=... --target-list=sparc-softmmu --enable-cocoa:

$ make >/dev/null
dyngen.c: In function 'get_reloc_name':
dyngen.c:1028: warning: pointer targets in passing argument 2 of  
'fetch_next_pair_value' differ in signedness
dyngen.c:1030: warning: pointer targets in passing argument 2 of  
'fetch_next_pair_value' differ in signedness
dyngen.c:1032: warning: pointer targets in passing argument 2 of  
'fetch_next_pair_value' differ in signedness
/Users/andreas/Q/myqemu/vl.c: In function `init_timer_alarm':
/Users/andreas/Q/myqemu/vl.c:1516: warning: `t' might be used  
uninitialized in this function
/Users/andreas/Q/myqemu/vl.c: At top level:
/Users/andreas/Q/myqemu/vl.c:1183: warning: `qemu_next_deadline'  
defined but not used
/Users/andreas/Q/myqemu/hw/eepro100.c:269: warning:  
`eepro100_mdi_mask' defined but not used
/Users/andreas/Q/myqemu/hw/pcnet.c:585: warning: `crctab' defined but  
not used
/Users/andreas/Q/myqemu/cocoa.m: In function `setApplicationMenu':
/Users/andreas/Q/myqemu/cocoa.m:860: warning: cannot find method `- 
setAppleMenu:'; return type `id' assumed
../dyngen-exec.h:229: warning: `__op_param1' defined but not used
../dyngen-exec.h:229: warning: `__op_param2' defined but not used
../dyngen-exec.h:229: warning: `__op_param3' defined but not used
../dyngen-exec.h:229: warning: `__op_param1' defined but not used
../dyngen-exec.h:229: warning: `__op_param2' defined but not used
../dyngen-exec.h:229: warning: `__op_param3' defined but not used

Signedness warnings appear to be quite common for cross-platform  
software on OS X and usually do not matter, the rest looks okay to me.
Just tell me if any additional information or debug output can help  
give you any idea.

Andreas