qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] Fix color problems with sdl on bgr displays


From: Avi Kivity
Subject: [Qemu-devel] [PATCH] Fix color problems with sdl on bgr displays
Date: Sun, 14 Oct 2007 15:52:15 +0200
User-agent: Thunderbird 2.0.0.0 (X11/20070419)

Some kvm users complained that the blue and red channels are flipped on their displays. Reverting sdl.c rev 1.40 fixed that problem, so apparently that commit made the problem larger than it was previously.

Attached a patch the removes the commit and fixes the problem. Please apply.

--
error compiling committee.c: too many arguments to function

Index: sdl.c
===================================================================
RCS file: /sources/qemu/qemu/sdl.c,v
retrieving revision 1.44
diff -u -r1.44 sdl.c
--- sdl.c       17 Sep 2007 08:09:45 -0000      1.44
+++ sdl.c       14 Oct 2007 13:49:37 -0000
@@ -87,7 +87,7 @@
     ds->data = screen->pixels;
     ds->linesize = screen->pitch;
     ds->depth = screen->format->BitsPerPixel;
-    if (screen->format->Bshift > screen->format->Rshift) {
+    if (ds->depth == 32 && screen->format->Rshift == 0) {
         ds->bgr = 1;
     } else {
         ds->bgr = 0;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]