Re: [Qemu-devel] [PATCH] syscall_target_errno.patch

[Thayne Harbaugh]

On Thu, 2007-10-11 at 14:10 +0200, J. Mayer wrote: 
> On Wed, 2007-10-10 at 21:38 -0600, Thayne Harbaugh wrote:

<SNIP>

> > I have noticed that many functions in syscall.c return a *host* errno
> > when a *target* errno should be return.  At the same time, there are
> > several places in syscall.c:do_syscall() that immediately return an
> > errno rather than setting the return value and exiting through the
> > syscall return value reporting at the end of do_syscall().
> > 
> > This patch addresses both of those problems at once rather than touching
> > the exact same errno return lines twice in do_syscall().  It also
> > touches a few functions in linux-user/signal.c that are called from
> > do_syscall().

<SNIP>

> Hi,
> 
> there are still a lot of problems hidden in syscalls.c and signal.c, as
> you noticed.
> Your patch seems OK to me and adding all those comments is imho really
> great.
> My only remark is a cosmetic one: I don't like too much hidding 'goto'
> in macros...

This is another version of the same patch that doesn't hide "goto" in a
macro.  It also makes do_sigaltstack() return target values which are
more like the other do_*() functions called from do_syscalls().

03_syscall_target_errno.patch
Description: Text Data