[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH, RFC] USB OHCI isochronous transfers support
|
From: |
Paul Brook |
|
Subject: |
Re: [Qemu-devel] [PATCH, RFC] USB OHCI isochronous transfers support |
|
Date: |
Mon, 22 Oct 2007 12:52:45 +0100 |
|
User-agent: |
KMail/1.9.7 |
On Monday 22 October 2007, Arnon Gilboa wrote:
> Hi,
>
> The attached patch adds isochronous transfers support to the OHCI
> emulation, similarly to the UHCI patch pushed two weeks ago.
> + uint16_t offset[8];
> +};
> +static inline int ohci_read_iso_td(uint32_t addr, struct ohci_iso_td *td)
> +{
> + return get_dwords(addr, (uint32_t *)td, sizeof(*td) >> 2);
> +}
This is wrong. It will break on big-endian hosts.
set_dwords only DTRT if all the structure fields are 32-bit.
Paul