[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qemu host-utils.c
From: |
J. Mayer |
Subject: |
Re: [Qemu-devel] qemu host-utils.c |
Date: |
Wed, 24 Oct 2007 12:35:36 +0200 |
On Wed, 2007-10-24 at 12:20 +0200, Fabrice Bellard wrote:
> I strongly suggest to reuse my code which was in target-i386/helper.c
> revision 1.80 which was far easier to validate. Moreover, integer
> divisions from target-i386/helper.c should be put in the same file.
I fully agree with this. I still use the same code in the PowerPC
op_helper.c file because I never conviced myself that the host_utils
version was bug-free. I would likely switch to the common version if I
could be sure it cannot lead to any regression.
> Thiemo Seufer wrote:
> > CVSROOT: /sources/qemu
> > Module name: qemu
> > Changes by: Thiemo Seufer <ths> 07/10/23 23:22:54
> >
> > Modified files:
> > . : host-utils.c
> >
> > Log message:
> > Fix overflow when multiplying two large positive numbers.
> >
> > CVSWeb URLs:
> > http://cvs.savannah.gnu.org/viewcvs/qemu/host-utils.c?cvsroot=qemu&r1=1.1&r2=1.2
> >
> >
> >
> >
>
>
>
--
J. Mayer <address@hidden>
Never organized