Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom

[Laurent Vivier]

address@hidden a écrit :
> On Mon, Oct 29, 2007 at 03:02:21PM +0100, Laurent Vivier wrote:
> > Daniel P. Berrange a écrit :
> > > On Sun, Oct 28, 2007 at 11:43:33PM +0100, address@hidden wrote:
> > > > From: Laurent Vivier <address@hidden(none)>
> > > >
> > > > This patch allows to define where is connected the CDROM device (bus,
> > > > unit).
> > > > It extends the "-cdrom" syntax to add these paramaters:
> > > >
> > > >     -cdrom file[,if=type][,bus=n][,unit=m]
> > > >
> > > > where "type" defines the interface (by default, "ide")
> > > >       "n" defines the bus number (by default 1)
> > > >       "m" defines the unit number (by default 0)
> > >
> > > Having a separately named arg just for CDROMs was always rather 
> > > odd/unhelpful.
> > > I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc 
> > > unchanged
> > > and use the -disk for setting up all types of disks, floppys, cdroms, etc. 
> > > It
> > > would just require one extra field for the -disk arg:
> > >
> > >      -disk file[,if=type][,bus=n][,unit=m][,mode=mode]
> > >
> > >  where "type" defines the interface. [ide,scsi,fd] (by default, "ide")
> > >        "n" defines the bus number (by default 1)
> > >        "m" defines the unit number (by default 0)
> > >        "mode" defines one of [disk,floppy,cdrom]
> > >
> > > If we ever up able to emulate other types of SCSI / IDE devices (tape 
> > > drives,
> > > cdr, dvd perhaps) then the 'mode' can easily be extended to cover them.
> > I agree with that. And if everyone agrees I can modify patches to do that...
> >
> > Laurent
> > --
> > ---------------- address@hidden  -----------------
> > "Given enough eyeballs, all bugs are shallow" E. S. Raymond
> not to be rude, but "my" version of the scsi patch supports three controllers,
> for a total of 21 disks. might i reccomend you impliment -disk with a 
> controller,
> bus, target syntax, ALA sun?

Well, IMHO, bus number should be enough, because the bus identify the 
controller... but we can discuss that later, as the syntax allows to add easily 
a "controller" arg to "-disk".

Laurent
--
---------------- address@hidden  -----------------
"Given enough eyeballs, all bugs are shallow" E. S. Raymond