Re: [Qemu-devel] [PATCH] strace rework

[Thiemo Seufer]

Thayne Harbaugh wrote:
> 
> On Thu, 2007-11-01 at 00:09 +0000, Thiemo Seufer wrote:
> > Thayne Harbaugh wrote:
> > > 
> > > On Sat, 2007-10-27 at 14:26 +0100, Thiemo Seufer wrote:
> > > > Thayne Harbaugh wrote:
> > > > > This is a rework of Stuart Anderson's strace patch.  I've fixed
> > > > > target-to-host and host-to-target syscall lookups so that the proper
> > > > > host or target errno is returned.
> > > > 
> > > > It didn't build for me due to the a missing target_to_host_errno
> > > > function.
> > > 
> > > This isn't obvious to me.  It also doesn't appear that you included this
> > > error in the output you sent.
> > > 
> > > >  Could you also have a look at the compiler warnings
> > > > from strace.c? I see e.g.:
> > > 
> > > <miles of warnings deleted>
> > > 
> > > Thank you for sending me the warnings.  I've reworked it so that
> > > function arguments are passed correctly, target addresses have access
> > > checked and locked and that proper print format codes are used.
> > > 
> > > Attached is the new version.  Please send me feedback.
> > 
> > Comitted. Could you also cook up a patch which documents the feature?
> 
> Awesome!  Thank you.
> 
> Yes, I'll be writing piles of documentation from user docs to
> development code guides.  Is there a directory that we can dump things
> into?

Not yet, but you can send a patch which creates a doc subdirectory. :-)


Thiemo