Re: [Qemu-devel] Removal of some target CPU macros

[Thiemo Seufer]

Fabrice Bellard wrote:
> I noticed that some target CPUs macros have been added while they do not
> seem necessary. I don't like that because it introduces more #ifdefs
> which prevent making a version supporting simultaneously all the CPUs.
> 
> In particular I saw the following:
> 
> - TARGET_MIPSN32 : it is always combined with TARGET_MIPS64 in
> target-mips/. If its only usage is to select a different Linux ABI, then
> I suggest keeping TARGET_MIPS64 and using another define to choose that.

I used both in combination to avoid unintended differences in CPU
behaviour. I agree it is somewhat ugly, and ABI specific defines
would be better. I will make a patch when I find time for it.


Thiemo