Re: [Qemu-devel] [PATCH 1/2][UPDATE] remove unused parameters from QEMUMachineInitFunc

[Blue Swirl]

On 11/12/07, Laurent Vivier <address@hidden> wrote:
>
> It appears that fd_filename and snapshot are not needed/used by machine
> init functions (QEMUMachineInitFunc).
>
> This patch removes them.

I don't know what was the idea for these parameters, so I can't
comment on the correctness of the patch in general.

>  /* SPARCstation 5 hardware initialisation */
> -static void ss5_init(int RAM_size, int vga_ram_size, const char *boot_device,
> -                       DisplayState *ds, const char **fd_filename, int 
> snapshot,
> +static void ss5_init(int RAM_size, int vga_ram_size,
> +                       const char *boot_device, DisplayState *ds,
>                         const char *kernel_filename, const char 
> *kernel_cmdline,
>                         const char *initrd_filename, const char *cpu_model)
>  {
> @@ -616,8 +616,8 @@ static void ss5_init(int RAM_size, int v
>  }
>
>  /* SPARCstation 10 hardware initialisation */
> -static void ss10_init(int RAM_size, int vga_ram_size, const char 
> *boot_device,
> -                            DisplayState *ds, const char **fd_filename, int 
> snapshot,
> +static void ss10_init(int RAM_size, int vga_ram_size,
> +                            const char *boot_device, DisplayState *ds,
>                              const char *kernel_filename, const char 
> *kernel_cmdline,
>                              const char *initrd_filename, const char 
> *cpu_model)

You didn't fix ss600mp_init, which was added yesterday.