[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O |
Date: |
Mon, 03 Dec 2007 11:30:04 +0100 |
Le lundi 03 décembre 2007 à 11:23 +0100, Fabrice Bellard a écrit :
> Laurent Vivier wrote:
> > This patch enhances the "-drive ,cache=off" mode with IDE drive emulation
> > by removing the buffer used in the IDE emulation.
> > ---
> > block.c | 10 +++
> > block.h | 2
> > block_int.h | 1
> > cpu-all.h | 1
> > exec.c | 19 ++++++
> > hw/ide.c | 176
> > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++---
> > vl.c | 1
> > 7 files changed, 204 insertions(+), 6 deletions(-)
>
> What's the use of keeping the buffered case ?
Well, I don't like to remove code written by others...
and I don't want to break something.
But if you think I should remove the buffered case, I can.
BTW, do you think I should enable "cache=off" by default ?
Or even remove the option from the command line and always use
O_DIRECT ?
Regards,
Laurent
--
------------- address@hidden --------------
"Any sufficiently advanced technology is
indistinguishable from magic." - Arthur C. Clarke
signature.asc
Description: Ceci est une partie de message numériquement signée
- [Qemu-devel] [PATCH 0/2 v2] Open disk images with O_DIRECT, Laurent Vivier, 2007/12/03
- [Qemu-devel] [PATCH 1/2 v2] Add "cache" parameter to "-drive", Laurent Vivier, 2007/12/03
- Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O, Anthony Liguori, 2007/12/03
- Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O, Samuel Thibault, 2007/12/03
- Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O, Paul Brook, 2007/12/03
- Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O, Jamie Lokier, 2007/12/03
- Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O, Anthony Liguori, 2007/12/03
- Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O, Jamie Lokier, 2007/12/03
- Re: [Qemu-devel] [PATCH 2/2 v2] Direct IDE I/O, Anthony Liguori, 2007/12/03