qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] qemu vl.c hw/omap.c


From: andrzej zaborowski
Subject: Re: [Qemu-devel] qemu vl.c hw/omap.c
Date: Tue, 4 Dec 2007 02:11:59 +0100

On 04/12/2007, Paul Brook <address@hidden> wrote:
> > Log message:
> >       Always create an SD bdrv, so that PXA and OMAP boards can boot with
> >       no card inserted again.  Eventually SD, CDROM and floppy should all
> >       be registered conditionally depending on machine.
>
> This seems the wrong way to solve this problem. The SD emulation should be
> able to cope with no device being present.

The bdrv's represent the concept of "drive" rather than "media", and
also in the case the bdrv must be present whenever there is a SD slot,
not an SD card (so that monitor command change and eject can be used).
I agree that not all machines have an SD slot, as not all machines
have a cd-rom drive or floppy drive.

So this needs to be fixed but this commit was a quick fix for the
regression from the -drive patch.
Regards




reply via email to

[Prev in Thread] Current Thread [Next in Thread]