[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM sup
From: |
Carlo Marcelo Arenas Belon |
Subject: |
Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support |
Date: |
Fri, 4 Jan 2008 20:06:47 -0600 |
User-agent: |
Mutt/1.4.1i |
On Sat, Jan 05, 2008 at 01:02:30AM +0000, Stuart Brady wrote:
> On Fri, Jan 04, 2008 at 06:25:25PM -0600, Rob Landley wrote:
> > On Friday 04 January 2008 04:02:07 Carlo Marcelo Arenas Belon wrote:
> >
> > > > - buf[7] = total_sectors <= 1433600 ? 0x08 : 0x10; /* current
> > > > profile */
> >
> > Where does the constant come from, anyway?
>
> 1433600? Seems it's the number of 512 KiB blocks in a 700 MiB CD image
> (700 * 1024 * 2).
yes, that magic constant corresponds to the maximum expected size for a CD-ROM
and is used to detect if the profile used should be for DVD-ROM or not.
It came from the original implementation patch for "GET CONFIGURATION"
committed in revision 1.66 of ide.c by Filip Navarra as
"Partial IDE DVD emulation"
http://cvs.savannah.nongnu.org/viewvc/qemu/hw/ide.c?root=qemu&r1=1.65&r2=1.66
Carlo
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Carlo Marcelo Arenas Belon, 2008/01/04
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Rob Landley, 2008/01/04
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Stuart Brady, 2008/01/04
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Stuart Brady, 2008/01/04
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support,
Carlo Marcelo Arenas Belon <=
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Rob Landley, 2008/01/04
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Stuart Brady, 2008/01/05
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Carlo Marcelo Arenas Belon, 2008/01/05
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Stuart Brady, 2008/01/06
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Andreas Färber, 2008/01/06
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Carlo Marcelo Arenas Belon, 2008/01/06
- Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Carlo Marcelo Arenas Belon, 2008/01/06
Re: [Qemu-devel] [RESEND] [PATCH] ide: fix GET_CONFIGURATION DVD-ROM support, Carlo Marcelo Arenas Belon, 2008/01/04