Re: [Qemu-devel] [PATCH 1/5] Fix i386 Host

[Alexander Graf]

On Jan 18, 2008, at 12:25 AM, Andreas Färber wrote:

> Am 17.01.2008 um 18:34 schrieb Alexander Graf:
>
> > > I tested sparc-softmmu, ppc-softmmu, ppc64-softmmu, i386-softmmu  
> > > on Linux/i386 from your gcc4 branch. It compiles okay on gcc (GCC)  
> > > 4.1.3 20070929 (prerelease) (Ubuntu 4.1.2-16ubuntu2). Runtime  
> > > behavior was identical to CVS+gcc-3.4.
> >
> > Could you please test gcc4 for PowerPC as well? I don't see a  
> > reason this should not work on OSX/PPC.
>
> As mentioned earlier, on OSX/ppc QEMU worked even without this patch  
> mostly (with always_inline fix applied), only when running Q I got  
> occasional crashes.

Using gcc4 on OSX/ppc still is not that bad of an idea. I don't know  
when Apple is going to drop support for gcc3, but I'm pretty sure they  
will. And since this is necessary for Linux/ppc anyway, why not check  
if it works on all platforms?

The performance hit (3% without kqemu as Michael measured) you get on  
i386 by using gcc4 does not affect ppc. So the only thing you get is  
more intelligent optimization, which might even make the gcc4 version  
faster.

> The gcc4 git branch plus always_inline fix compiles sparc-softmmu  
> fine on powerpc-apple-darwin9-gcc-4.0.1 (GCC) 4.0.1 (Apple Inc.  
> build 5465). As usual there are some signedness warnings. It ran as  
> fine as without the fix. The other softmmus and the combination with  
> Q I haven't checked yet.
>
> Is this patch supposed to work on OSX/i386 as well as is, or does  
> that require some of the existing patches?

You still need support for Mach-O on i386. I'll leave that part to  
Mike Kronenberg though ;-).

Alex