Re: [Qemu-devel] [PATCH][PPC] Use float32/64 instead of float/double

[Blue Swirl]

On 1/23/08, Aurelien Jarno <address@hidden> wrote:
> Aurelien Jarno a écrit :
> > On Sun, Dec 30, 2007 at 06:32:45PM +0200, Blue Swirl wrote:
> >> On 12/30/07, Aurelien Jarno <address@hidden> wrote:
> >>> The patch below changes the float and double types into float32 and
> >>> and float64 types in the PPC code. This doesn't change anything when
> >>> using softfloat-native as the types are the same, but that helps
> >>> compiling the PPC target with softfloat.
> >> You could also consider replacing the unions with the common
> >> definition CPU_DoubleU in cpu-all.h and also add CPU_FloatU.
> >
> > Good idea. Please find and updated patch below.
> >
> >
> > The patch below uses the float32 and float64 types instead of the float
> > and double types in the PPC code. This doesn't change anything when
> > using softfloat-native as the types are the same, but that helps
> > compiling the PPC target with softfloat.
> >
> > It also defines a new union CPU_FloatU in addition to CPU_DoubleU, and
> > use them instead of identical unions that are defined in numerous
> > places.
> >
> >  cpu-all.h                  |    5
> >  target-ppc/op.c            |   83 ++------
> >  target-ppc/op_helper.c     |  418 
> > +++++++++++++++------------------------------
> >  target-ppc/op_helper.h     |  104 +++--------
> >  target-ppc/op_helper_mem.h |   18 -
> >  target-ppc/op_mem.h        |   69 ++-----
> >  6 files changed, 240 insertions(+), 457 deletions(-)
>
>
> Any news about this patch?

Looks OK to me, but I can't test it. Anyway it's better to wait a bit
for Fabrice's new code generator.